added example of github pushing to s3, using oidc #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
andyblundell
requested changes
Apr 18, 2023
| 11Error: Process completed with exit code 1. | ||
|
|
||
| Ensure Role: fails when has wrong GitHub Repo name: | ||
| - AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub Repo in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigitalWRONG/tech-radar:ref:refs/heads/main" |
There was a problem hiding this comment.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
| - But took 2min, seemed to be timing out / retrying | ||
|
|
||
| Ensure Role fails when has wrong GitHub Branch name: | ||
| - AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub branch in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigital/tech-radar:ref:refs/heads/mainWRONG" |
There was a problem hiding this comment.
Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)
There was a problem hiding this comment.
It might be worth noting that I've done some work to create a reusable terraform module that does this. https://github.com/NHSDigital/ee-terraform-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.